feature: allow hooks to override nested struct type#183
Open
iamtakingiteasy wants to merge 1 commit intogo-viper:mainfrom
Open
feature: allow hooks to override nested struct type#183iamtakingiteasy wants to merge 1 commit intogo-viper:mainfrom
iamtakingiteasy wants to merge 1 commit intogo-viper:mainfrom
Conversation
Signed-off-by: Alexander Tumin <iamtakingiteasy@eientei.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementation of #43, #36
Currently hooks are only queried after target type for nested struct is determined which cannot be changed from map, this MR introduces hook dispatch early at struct field processing, allowing to replace field with type other than map.
Main use-case is rendering
time.Time(which is a struct with no exported fields) as a string.Partially addresses #165 (at least allows proposed hook solution to function as expected).
Changes conflict with #176, a rebase of other will be necessary if either is merged.